Skip to content

bpo-33281: Change some ifs to be elifs so the correct find_library is not later overridden.#6625

Merged
ned-deily merged 1 commit into
python:masterfrom
mingwandroid:master
May 2, 2018
Merged

bpo-33281: Change some ifs to be elifs so the correct find_library is not later overridden.#6625
ned-deily merged 1 commit into
python:masterfrom
mingwandroid:master

Conversation

@mingwandroid
Copy link
Copy Markdown
Contributor

@mingwandroid mingwandroid commented Apr 28, 2018

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@mingwandroid
Copy link
Copy Markdown
Contributor Author

I have signed the CLA now and associated my github tag with my account on bugs.python.org, what next?

@ned-deily
Copy link
Copy Markdown
Member

@mingwandroid, It looks you still need to add your GitHub user name to your bugs.python.org user account (https://bugs.python.org/user16077). I'll do it for you here.

@ned-deily
Copy link
Copy Markdown
Member

@mingwandroid, The patch looks good to me, thanks! If, in the next few hours, you could also push a NEWS entry to the PR using the blurb utility, that would be great.

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @mingwandroid for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2018
…-6625)

(cherry picked from commit d06d345)

Co-authored-by: Ray Donnelly <mingw.android@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

GH-6680 is a backport of this pull request to the 3.7 branch.

ned-deily pushed a commit that referenced this pull request May 2, 2018
…GH-6680)

(cherry picked from commit d06d345)

Co-authored-by: Ray Donnelly <mingw.android@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants